New answers tagged

0

There's no right answer here in particular; mostly it depends on how your team agrees to use the GitHub PRs. If you "Start a Review", then in addition to saving up all the comments & notifying the user once, as Nezih mentioned, GitHub will also require you to choose "Approve", "Request Changes", or "Comment". If ...


2

That's a good feature in GitHub. When you add a single comment, the reviewers of the PR are notified immediately. I don't use that. I start a review, make all my comments, and finish my review. By doing that, the reviewers are notified of all my comments at once. If you even change a single character in the code, it is neither a comment nor a code review; it'...


Top 50 recent answers are included